WARP Project Forums - Wireless Open-Access Research Platform

You are not logged in.

#1 2013-Nov-06 10:10:23

asethi
Member
Registered: 2013-Oct-23
Posts: 15

minor typo in warpphy.c

Hi,

While going through the code of warpphy_init(), I believe I saw a minor typo at line 175, warpphy.c

Code:

//Set Rx bandwidth; 0x0 = 15MHz (minimum)
radio_controller_setRadioParam(RC_BASEADDR, (RC_RFA | RC_RFB), RC_PARAMID_TXLPF_BW, 0);

the parameter RC_PARAMID_TXLPF_BW is being set to an invalid value 0. Furthermore, TX lpf has already been configured at line154. The parameter which was supposed to be configured in line 175 was RC_PARAMID_RXLPF_BW, for which 0 is a valid value.

I am using ofdm reference design v18.1

BR

Offline

 

#2 2013-Nov-07 09:41:50

murphpo
Administrator
From: Mango Communications
Registered: 2006-Jul-03
Posts: 5159

Re: minor typo in warpphy.c

Yep, definitely a typo. Thanks for letting us know. I just fixed warpphy.c in svn.

Thankfully the effect wasn't catastrophic- the radio_controller driver would punt for RC_PARAMID_TXLPF_BW=0, and the default RXLPF_BW works fine for the OFDM ref design, albeit with a little extra noise admitted outside the occupied bandwidth.

Offline

 

Board footer